From 1fc6fd66ffafd42ca99e67da99a45cdc0ec0e948 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 11 Dec 2021 03:00:00 -0800 Subject: [PATCH] build: fix commit-queue-rebase functionality MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: https://github.com/nodejs/node/pull/41140 Reviewed-By: Antoine du Hamel Reviewed-By: Ruben Bridgewater Reviewed-By: Michaël Zasso --- .github/workflows/commit-queue.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/commit-queue.yml b/.github/workflows/commit-queue.yml index 0dc7c4d5c3f9de..54b114b7b7e813 100644 --- a/.github/workflows/commit-queue.yml +++ b/.github/workflows/commit-queue.yml @@ -26,7 +26,6 @@ jobs: # Needs the whole git history for ncu to work # See https://github.com/nodejs/node-core-utils/pull/486 fetch-depth: 0 - persist-credentials: false # A personal token is required because pushing with GITHUB_TOKEN will # prevent commits from running CI after they land. It needs # to be set here because `checkout` configures GitHub authentication