From 22a9fe35520f7eb89845237582262457721afc70 Mon Sep 17 00:00:00 2001 From: ZYSzys <17367077526@163.com> Date: Tue, 15 Jan 2019 11:39:20 +0800 Subject: [PATCH] test: add test for net-socket-setTimeout callback PR-URL: https://github.com/nodejs/node/pull/25084 Refs: https://github.com/nodejs/node/issues/19060 Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina --- test/parallel/test-net-socket-timeout.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/test/parallel/test-net-socket-timeout.js b/test/parallel/test-net-socket-timeout.js index a30ab8ce293764..f0f5f194bf304c 100644 --- a/test/parallel/test-net-socket-timeout.js +++ b/test/parallel/test-net-socket-timeout.js @@ -31,6 +31,9 @@ const nonNumericDelays = [ ]; const badRangeDelays = [-0.001, -1, -Infinity, Infinity, NaN]; const validDelays = [0, 0.001, 1, 1e6]; +const invalidCallbacks = [ + 1, '100', true, false, null, {}, [], Symbol('test') +]; for (let i = 0; i < nonNumericDelays.length; i++) { @@ -49,6 +52,19 @@ for (let i = 0; i < validDelays.length; i++) { s.setTimeout(validDelays[i], () => {}); } +for (let i = 0; i < invalidCallbacks.length; i++) { + [0, 1].forEach((mesc) => + common.expectsError( + () => s.setTimeout(mesc, invalidCallbacks[i]), + { + code: 'ERR_INVALID_CALLBACK', + type: TypeError, + message: 'Callback must be a function' + } + ) + ); +} + const server = net.Server(); server.listen(0, common.mustCall(() => { const socket = net.createConnection(server.address().port);