Skip to content

Commit

Permalink
build: indicate that configure has done something
Browse files Browse the repository at this point in the history
If run without `--verbose` configure exits silently with no indication
that it has done anything. Print a message on completion to indicate
that the script has worked.

Refs: #23111

PR-URL: #26436
Refs: #23111
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
richardlau authored and BridgeAR committed Mar 14, 2019
1 parent c247153 commit 240de93
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions configure.py
Original file line number Diff line number Diff line change
@@ -1696,3 +1696,4 @@ def make_bin_override():

print_verbose("running: \n " + " ".join(['python', 'tools/gyp_node.py'] + gyp_args))
run_gyp(gyp_args)
info('configure completed successfully')

0 comments on commit 240de93

Please sign in to comment.