From 24f3f1160659ebb83416a2c779abf9d0e87ed0d6 Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Sun, 17 Feb 2019 21:19:53 +0100
Subject: [PATCH] src: move function from header to source file

This particular Buffer::New() overload used to live in node_internals.h
to work around a cyclic header dependency (IIRC) but that is no longer
necessary.

PR-URL: https://github.com/nodejs/node/pull/26173
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 src/node_buffer.cc   | 14 ++++++++++++++
 src/node_internals.h | 14 --------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/node_buffer.cc b/src/node_buffer.cc
index 39727fcdd14179..9fed15622e05d5 100644
--- a/src/node_buffer.cc
+++ b/src/node_buffer.cc
@@ -234,6 +234,20 @@ size_t Length(Local<Object> obj) {
 }
 
 
+inline MaybeLocal<Uint8Array> New(Environment* env,
+                                  Local<ArrayBuffer> ab,
+                                  size_t byte_offset,
+                                  size_t length) {
+  CHECK(!env->buffer_prototype_object().IsEmpty());
+  Local<Uint8Array> ui = Uint8Array::New(ab, byte_offset, length);
+  Maybe<bool> mb =
+      ui->SetPrototype(env->context(), env->buffer_prototype_object());
+  if (mb.IsNothing())
+    return MaybeLocal<Uint8Array>();
+  return ui;
+}
+
+
 MaybeLocal<Object> New(Isolate* isolate,
                        Local<String> string,
                        enum encoding enc) {
diff --git a/src/node_internals.h b/src/node_internals.h
index 367df26c0e74f6..6f09708371b97c 100644
--- a/src/node_internals.h
+++ b/src/node_internals.h
@@ -128,20 +128,6 @@ v8::MaybeLocal<v8::Object> New(Environment* env,
 // Mixing operator new and free() is undefined behavior so don't do that.
 v8::MaybeLocal<v8::Object> New(Environment* env, char* data, size_t length);
 
-inline
-v8::MaybeLocal<v8::Uint8Array> New(Environment* env,
-                                   v8::Local<v8::ArrayBuffer> ab,
-                                   size_t byte_offset,
-                                   size_t length) {
-  v8::Local<v8::Uint8Array> ui = v8::Uint8Array::New(ab, byte_offset, length);
-  CHECK(!env->buffer_prototype_object().IsEmpty());
-  v8::Maybe<bool> mb =
-      ui->SetPrototype(env->context(), env->buffer_prototype_object());
-  if (mb.IsNothing())
-    return v8::MaybeLocal<v8::Uint8Array>();
-  return ui;
-}
-
 // Construct a Buffer from a MaybeStackBuffer (and also its subclasses like
 // Utf8Value and TwoByteValue).
 // If |buf| is invalidated, an empty MaybeLocal is returned, and nothing is