From 2551c1d2caaec21a5098de8e86274e0daf7aa781 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 13 Mar 2015 21:54:40 +0100 Subject: [PATCH] src: use Number::New() for heapTotal/heapUsed With --max_old_space_size=12345 it's possible to create a JS heap that is larger than what fits in an unsigned int so use Number::New() rather than Integer::NewFromUnsigned(). Performance-wise, it doesn't matter much. If V8 can fit the double in a SMI, it will. PR-URL: https://github.com/iojs/io.js/pull/1148 Reviewed-By: Trevor Norris --- src/node.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/node.cc b/src/node.cc index ba4118a6eb1766..5e906fe68430e4 100644 --- a/src/node.cc +++ b/src/node.cc @@ -1932,10 +1932,10 @@ void MemoryUsage(const FunctionCallbackInfo& args) { HeapStatistics v8_heap_stats; env->isolate()->GetHeapStatistics(&v8_heap_stats); - Local heap_total = - Integer::NewFromUnsigned(env->isolate(), v8_heap_stats.total_heap_size()); - Local heap_used = - Integer::NewFromUnsigned(env->isolate(), v8_heap_stats.used_heap_size()); + Local heap_total = + Number::New(env->isolate(), v8_heap_stats.total_heap_size()); + Local heap_used = + Number::New(env->isolate(), v8_heap_stats.used_heap_size()); Local info = Object::New(env->isolate()); info->Set(env->rss_string(), Number::New(env->isolate(), rss));