From 2c85db5247d8290afd75dc3ff2dafa799b90b4ab Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Fri, 8 Jun 2018 07:13:55 +0200 Subject: [PATCH] test: add crypto check to test-http2-debug This commit adds a crypto check to test-http2-debug.js as it currently will error if configured --without-ssl. The issue here is that the while the test spawns a child process that runs test-http2-ping.js, which does have a crypto check, it will just print '1..0 # Skipped: missing crypto' to stdout, and nothing to stderr which is what this test is trying to assert and hence failing. PR-URL: https://github.com/nodejs/node/pull/21205 Reviewed-By: Daijiro Wachi Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- test/parallel/test-http2-debug.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-http2-debug.js b/test/parallel/test-http2-debug.js index f329a7e57e79dd..e80c9e362815fd 100644 --- a/test/parallel/test-http2-debug.js +++ b/test/parallel/test-http2-debug.js @@ -1,5 +1,7 @@ 'use strict'; -require('../common'); +const common = require('../common'); +if (!common.hasCrypto) + common.skip('missing crypto'); const assert = require('assert'); const child_process = require('child_process'); const path = require('path');