From 2db83fdc0c3feca60a9dadacaf4fbc1e5e6c6cf9 Mon Sep 17 00:00:00 2001 From: Francesco Falanga Date: Sun, 13 May 2018 18:29:25 +0200 Subject: [PATCH] test: remove deepStrictEqual() third argument The call to assert.deepStrictEqual() has a string literal for its third argument. Unfortunately, a side effect of that is that the values of the first two arguments are not displayed if there is an AssertionError. That information is useful for debugging. PR-URL: https://github.com/nodejs/node/pull/20702 Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Anna Henningsen --- test/parallel/test-net-socket-local-address.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-net-socket-local-address.js b/test/parallel/test-net-socket-local-address.js index c4f11db76bc4f2..1aa51e0c5c1d87 100644 --- a/test/parallel/test-net-socket-local-address.js +++ b/test/parallel/test-net-socket-local-address.js @@ -17,8 +17,8 @@ const server = net.createServer((socket) => { }); server.on('close', common.mustCall(() => { - assert.deepStrictEqual(clientLocalPorts, serverRemotePorts, - 'client and server should agree on the ports used'); + // client and server should agree on the ports used + assert.deepStrictEqual(clientLocalPorts, serverRemotePorts); assert.strictEqual(2, conns); }));