From 2e76df5b4ef05136f837dcfbe1f67036825a075e Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Fri, 3 Nov 2017 23:10:10 -0200 Subject: [PATCH] doc: warn users about non-ASCII paths on build The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: https://github.com/nodejs/node/pull/16735 Refs: https://github.com/nodejs/node/issues/16278 Refs: https://github.com/nodejs/node/issues/14336 Reviewed-By: Gibson Fahnestock Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Joyee Cheung --- BUILDING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 95d62c481cce80..3f82fe0dd7619c 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -215,7 +215,8 @@ Prerequisites: [Git for Windows](http://git-scm.com/download/win) includes Git Bash and tools which can be included in the global `PATH`. -If the path to your build directory contains a space, the build will likely fail. +If the path to your build directory contains a space or a non-ASCII character, the +build will likely fail. ```console > .\vcbuild nosign