From 2f477bd34de128683c8d183e759b8f098205b1c9 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Fri, 1 Feb 2019 22:03:47 -0500 Subject: [PATCH] build,win: mark x86 image as not SAFESEH Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers PR-URL: https://github.com/nodejs/node/pull/25852 Reviewed-By: Ujjwal Sharma Reviewed-By: Matteo Collina Reviewed-By: Ali Ijaz Sheikh --- node.gypi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/node.gypi b/node.gypi index f528a2082ea48d..7f7ea0aa2cb5fd 100644 --- a/node.gypi +++ b/node.gypi @@ -35,6 +35,13 @@ '-Werror=undefined-inline', ], }, + # Relevant only for x86. + # Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers + 'msvs_settings': { + 'VCLinkerTool': { + 'ImageHasSafeExceptionHandlers': 'false', + }, + }, 'conditions': [ [ 'clang==1', { 'cflags': [ '-Werror=undefined-inline', ]