From 3238bff3b339371cfee4ec5e4d4af78ebf734b96 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 24 Mar 2016 15:11:36 -0700 Subject: [PATCH] test: confirm globals not used internally PR-URL: https://github.com/nodejs/node/pull/5882 Reviewed-By: James M Snell Reviewed-By: Jeremiah Senkpiel --- test/parallel/test-timers-api-refs.js | 29 ++++++++++++++------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/test/parallel/test-timers-api-refs.js b/test/parallel/test-timers-api-refs.js index 00d1c1355fe045..c062369444b1e0 100644 --- a/test/parallel/test-timers-api-refs.js +++ b/test/parallel/test-timers-api-refs.js @@ -1,20 +1,21 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); +const timers = require('timers'); -// don't verify the globals for this test -common.globalCheck = false; +// delete global APIs to make sure they're not relied on by the internal timers +// code +delete global.setTimeout; +delete global.clearTimeout; +delete global.setInterval; +delete global.clearInterval; +delete global.setImmediate; +delete global.clearImmediate; -// try overriding global APIs to make sure -// they're not relied on by the timers -global.clearTimeout = assert.fail; +const timeoutCallback = () => { timers.clearTimeout(timeout); }; +const timeout = timers.setTimeout(common.mustCall(timeoutCallback), 1); -// run timeouts/intervals through the paces -const intv = setInterval(function() {}, 1); - -setTimeout(function() { - clearInterval(intv); -}, 100); - -setTimeout(function() {}, 2); +const intervalCallback = () => { timers.clearInterval(interval); }; +const interval = timers.setInterval(common.mustCall(intervalCallback), 1); +const immediateCallback = () => { timers.clearImmediate(immediate); }; +const immediate = timers.setImmediate(immediateCallback);