From 32ec034bdc99944d6f3457c52933ba0aa9881c19 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 1 Apr 2019 10:45:53 +0200 Subject: [PATCH] src: use sizeof(var) instead of sizeof(type) Change `memset(&s, 0, sizeof(type))` to `memset(&s, 0, sizeof(s))`. The former is dangerous when the type of `s` changes. PR-URL: https://github.com/nodejs/node/pull/27038 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno Signed-off-by: Beth Griggs --- src/cares_wrap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index aeb525b33e7efa..6c6fca53312158 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1969,7 +1969,7 @@ void GetAddrInfo(const FunctionCallbackInfo& args) { args[4]->IsTrue()); struct addrinfo hints; - memset(&hints, 0, sizeof(struct addrinfo)); + memset(&hints, 0, sizeof(hints)); hints.ai_family = family; hints.ai_socktype = SOCK_STREAM; hints.ai_flags = flags;