Skip to content

Commit

Permalink
test: skip stringbytes-external-exceed-max on AIX
Browse files Browse the repository at this point in the history
Add SKIP status for more tests in stringbytes-external-exceed-max that
are failing on AIX.

PR-URL: #28516
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
sam-github authored and targos committed Jul 20, 2019
1 parent 7d3ddfe commit 33ab37f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
19 changes: 19 additions & 0 deletions test/addons/addon.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
prefix addons

[true] # This section applies to all platforms

[$system==aix]
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP

# https://github.com/nodejs/node/pull/28516
stringbytes-external-exceed-max/test-stringbytes-external-at-max: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-utf8: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2: SKIP
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: SKIP
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);

// v8 fails silently if string length > v8::String::kMaxLength
Expand Down

0 comments on commit 33ab37f

Please sign in to comment.