From 33cbdb33e43440f3fa88f36510403e8fabd49b72 Mon Sep 17 00:00:00 2001
From: Michael Dawson <mdawson@devrus.com>
Date: Mon, 21 Mar 2022 13:48:27 -0400
Subject: [PATCH] src: address 3 useless call coverity warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the last 3 useless call reports from coverity

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
---
 src/inspector_js_api.cc | 4 ++--
 src/node_http2.cc       | 1 -
 src/node_url.cc         | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
index 8de1f8e7b0a88d..e605c1c4d6f087 100644
--- a/src/inspector_js_api.cc
+++ b/src/inspector_js_api.cc
@@ -215,10 +215,10 @@ void InspectorConsoleCall(const FunctionCallbackInfo<Value>& info) {
 
   Local<Value> node_method = info[1];
   CHECK(node_method->IsFunction());
-  node_method.As<Function>()->Call(context,
+  USE(node_method.As<Function>()->Call(context,
                                    info.Holder(),
                                    call_args.length(),
-                                   call_args.out()).FromMaybe(Local<Value>());
+                                   call_args.out()));
 }
 
 static void* GetAsyncTask(int64_t asyncId) {
diff --git a/src/node_http2.cc b/src/node_http2.cc
index cf1aa81d32c3ae..e0786677264b2e 100644
--- a/src/node_http2.cc
+++ b/src/node_http2.cc
@@ -2646,7 +2646,6 @@ void Http2Session::New(const FunctionCallbackInfo<Value>& args) {
       static_cast<SessionType>(
           args[0]->Int32Value(env->context()).ToChecked());
   Http2Session* session = new Http2Session(state, args.This(), type);
-  session->get_async_id();  // avoid compiler warning
   Debug(session, "session created");
 }
 
diff --git a/src/node_url.cc b/src/node_url.cc
index 9f22fa069804f5..b13c94f030fa59 100644
--- a/src/node_url.cc
+++ b/src/node_url.cc
@@ -1666,7 +1666,7 @@ void Parse(Environment* env,
       null,  // fragment defaults to null
     };
     SetArgs(env, argv, url);
-    cb->Call(context, recv, arraysize(argv), argv).FromMaybe(Local<Value>());
+    USE(cb->Call(context, recv, arraysize(argv), argv));
   } else if (error_cb->IsFunction()) {
     Local<Value> flags = Integer::NewFromUnsigned(isolate, url.flags);
     USE(error_cb.As<Function>()->Call(context, recv, 1, &flags));