From 33fead3f5e4d8458f4640d032c0eb91bb747347a Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 29 Apr 2019 01:35:07 +0200 Subject: [PATCH] Revert "test: skip test-cpu-prof in debug builds with code cache" Skipping the test is not needed now that the underlying cause has been addressed in V8. This reverts commit b66f01d9037a120a8aad624c57e769fb418ccd9c. Refs: https://github.com/nodejs/node/pull/27423 PR-URL: https://github.com/nodejs/node/pull/27469 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung Reviewed-By: Colin Ihrig --- test/sequential/test-cpu-prof.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/test/sequential/test-cpu-prof.js b/test/sequential/test-cpu-prof.js index 726f99b799db31..19c8afd92cd5b9 100644 --- a/test/sequential/test-cpu-prof.js +++ b/test/sequential/test-cpu-prof.js @@ -3,12 +3,6 @@ // This tests that --cpu-prof, --cpu-prof-dir and --cpu-prof-name works. const common = require('../common'); -if (process.features.debug && process.features.cached_builtins) { - // FIXME(joyeecheung): the profiler crashes when code cache - // is enabled in debug builds. - common.skip('--cpu-prof does not work in debug builds with code cache'); -} - const fixtures = require('../common/fixtures'); common.skipIfInspectorDisabled();