From 3531fe9320c0b98ce01238ee07812306e716c4bd Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Wed, 13 Mar 2019 17:55:15 -0400 Subject: [PATCH] build,deps: add `NOMINMAX` to V8 Windows builds Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620 PR-URL: https://github.com/nodejs/node/pull/25852 Reviewed-By: Ujjwal Sharma Reviewed-By: Matteo Collina Reviewed-By: Ali Ijaz Sheikh --- deps/v8/gypfiles/toolchain.gypi | 1 + 1 file changed, 1 insertion(+) diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi index 10109024ba3ba3..eaac19592a87de 100644 --- a/deps/v8/gypfiles/toolchain.gypi +++ b/deps/v8/gypfiles/toolchain.gypi @@ -996,6 +996,7 @@ ['OS=="win"', { 'defines': [ 'WIN32', + 'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620 ], # 4351: VS 2005 and later are warning us that they've fixed a bug # present in VS 2003 and earlier.