From 37e386f91933602de4891d49c87c573f16117f8e Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Mon, 13 Jan 2020 19:54:36 -0500 Subject: [PATCH] build: do not use setup-node in build workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The setup-node GitHub Action installs problem matchers that happen to match the warning message format of Visual Studio's C/C++ compiler. This is resulting in all of our pull requests being annotated with `Unchanged files with check annotations` which are confusing to new contributors as they are not due to the changes in the pull request. The action is used to run `npx envinfo` to dump some information into the logs before the actual build. All GitHub hosted runners already have a version of Node.js installed (12.x at the time of this commit) which we can use to run `envinfo`. Remove the action to avoid using the problematic problem matcher. PR-URL: https://github.com/nodejs/node/pull/31349 Fixes: https://github.com/nodejs/node/issues/31347 Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso Reviewed-By: Sam Roberts Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott --- .github/workflows/CI.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 257e4abbc10aca..d2936382528b0d 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -7,10 +7,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Use Node.js 13 - uses: actions/setup-node@v1 - with: - node-version: 13.x - name: Environment Information run: npx envinfo - name: Build @@ -19,10 +15,6 @@ jobs: runs-on: windows-latest steps: - uses: actions/checkout@v2 - - name: Use Node.js 13 - uses: actions/setup-node@v1 - with: - node-version: 13.x - name: Environment Information run: npx envinfo - name: Install deps @@ -33,10 +25,6 @@ jobs: runs-on: macos-latest steps: - uses: actions/checkout@v2 - - name: Use Node.js 13 - uses: actions/setup-node@v1 - with: - node-version: 13.x - name: Environment Information run: npx envinfo - name: Build