From 38fdbcd7f774bc7f828b9481123b493daf55f195 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 30 Sep 2016 16:12:27 +0200 Subject: [PATCH] build: make addons build dep. on node_version.h Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff876ba62ed58664eb011a863d0960f4089b. PR-URL: https://github.com/nodejs/node/pull/8861 Reviewed-By: Colin Ihrig Reviewed-By: Ilkka Myller Reviewed-By: Ben Noordhuis --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c82dfa53965ffa..0773088c5ded87 100644 --- a/Makefile +++ b/Makefile @@ -162,7 +162,7 @@ test/addons/.buildstamp: config.gypi \ deps/npm/node_modules/node-gyp/package.json \ $(ADDONS_BINDING_GYPS) $(ADDONS_BINDING_SOURCES) \ deps/uv/include/*.h deps/v8/include/*.h \ - src/node.h src/node_buffer.h src/node_object_wrap.h \ + src/node.h src/node_buffer.h src/node_object_wrap.h src/node_version.h \ test/addons/.docbuildstamp # Cannot use $(wildcard test/addons/*/) here, it's evaluated before # embedded addons have been generated from the documentation.