From 4011be0d19cedbb0afd16e46851f981fb75e683b Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 23 Dec 2021 15:19:19 -0800 Subject: [PATCH] tools: use {N} for spaces in regex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Spaces are hard to count. Use {N} notation to indicate how many spaces in regular expressions in find-inactive-collaborators. PR-URL: https://github.com/nodejs/node/pull/41295 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca --- tools/find-inactive-collaborators.mjs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/find-inactive-collaborators.mjs b/tools/find-inactive-collaborators.mjs index 4d7802a0ed30f5..e01b29ac5f9f23 100755 --- a/tools/find-inactive-collaborators.mjs +++ b/tools/find-inactive-collaborators.mjs @@ -49,7 +49,7 @@ const authors = await runGitCommand( // Get all approving reviewers of landed commits during the time period. const approvingReviewers = await runGitCommand( `git log --since="${SINCE}" | egrep "^ Reviewed-By: "`, - (line) => /^ Reviewed-By: ([^<]+)/.exec(line)[1].trim() + (line) => /^ {4}Reviewed-By: ([^<]+)/.exec(line)[1].trim() ); async function getCollaboratorsFromReadme() { @@ -72,7 +72,7 @@ async function getCollaboratorsFromReadme() { foundCollaboratorHeading = true; } if (line.startsWith(' **') && isCollaborator) { - const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line); + const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line); const mailmap = await runGitCommand( `git check-mailmap '${name} <${email}>'` ); @@ -136,7 +136,7 @@ async function moveCollaboratorToEmeritus(peopleToMove) { if (line.startsWith('* ')) { collaboratorFirstLine = line; } else if (line.startsWith(' **')) { - const [, name, email] = /^ \*\*([^*]+)\*\* <<(.+)>>/.exec(line); + const [, name, email] = /^ {2}\*\*([^*]+)\*\* <<(.+)>>/.exec(line); if (peopleToMove.some((entry) => { return entry.name === name && entry.email === email; })) {