From 466601f47f599e138a18e42c5a0be2dbafd1f8ef Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 18 Jun 2018 05:26:43 +0200 Subject: [PATCH] src: remove .h if -inl.h is already included This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: https://github.com/nodejs/node/pull/21381 Reviewed-By: Matheus Marchini Reviewed-By: Gus Caplan Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Ujjwal Sharma --- src/bootstrapper.cc | 1 - src/callback_scope.cc | 2 -- src/exceptions.cc | 2 -- src/node_encoding.cc | 2 -- src/node_platform.cc | 1 - src/node_process.cc | 2 -- 6 files changed, 10 deletions(-) diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc index c470b99445fbd1..8bcc0493f5be6d 100644 --- a/src/bootstrapper.cc +++ b/src/bootstrapper.cc @@ -1,5 +1,4 @@ #include "node.h" -#include "env.h" #include "env-inl.h" #include "node_internals.h" #include "v8.h" diff --git a/src/callback_scope.cc b/src/callback_scope.cc index 23e6d5b0632f2c..feb7e23b6e5f84 100644 --- a/src/callback_scope.cc +++ b/src/callback_scope.cc @@ -1,7 +1,5 @@ #include "node.h" -#include "async_wrap.h" #include "async_wrap-inl.h" -#include "env.h" #include "env-inl.h" #include "v8.h" diff --git a/src/exceptions.cc b/src/exceptions.cc index 0007854595a467..4bd5ab13134c86 100644 --- a/src/exceptions.cc +++ b/src/exceptions.cc @@ -1,8 +1,6 @@ #include "node.h" #include "node_internals.h" -#include "env.h" #include "env-inl.h" -#include "util.h" #include "util-inl.h" #include "v8.h" #include "uv.h" diff --git a/src/node_encoding.cc b/src/node_encoding.cc index 467f04e24568cb..d5c6bcab488dd2 100644 --- a/src/node_encoding.cc +++ b/src/node_encoding.cc @@ -1,8 +1,6 @@ #include "node.h" -#include "env.h" #include "env-inl.h" #include "string_bytes.h" -#include "util.h" #include "util-inl.h" #include "v8.h" diff --git a/src/node_platform.cc b/src/node_platform.cc index fdca115e5f8f03..947622a219cdef 100644 --- a/src/node_platform.cc +++ b/src/node_platform.cc @@ -1,7 +1,6 @@ #include "node_platform.h" #include "node_internals.h" -#include "env.h" #include "env-inl.h" #include "util.h" #include diff --git a/src/node_process.cc b/src/node_process.cc index 04cf577dba538f..43982e6f39f769 100644 --- a/src/node_process.cc +++ b/src/node_process.cc @@ -1,8 +1,6 @@ #include "node.h" #include "node_internals.h" -#include "env.h" #include "env-inl.h" -#include "util.h" #include "util-inl.h" #include "uv.h" #include "v8.h"