Skip to content

Commit

Permalink
internal: rename error-serdes for consistency
Browse files Browse the repository at this point in the history
All other JavaScript files in lib use snake case, so make this
one consistent.

PR-URL: #33793
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
evanlucas authored and addaleax committed Sep 28, 2020
1 parent 9f16b7f commit 4a2accb
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 5 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion lib/internal/main/worker_thread.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ function workerOnGlobalUncaughtException(error, fromPromise) {

let serialized;
try {
const { serializeError } = require('internal/error-serdes');
const { serializeError } = require('internal/error_serdes');
serialized = serializeError(error);
} catch {}
debug(`[${threadId}] uncaught exception serialized = ${!!serialized}`);
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const {
ReadableWorkerStdio,
WritableWorkerStdio
} = workerIo;
const { deserializeError } = require('internal/error-serdes');
const { deserializeError } = require('internal/error_serdes');
const { fileURLToPath, isURLInstance, pathToFileURL } = require('internal/url');

const {
Expand Down
2 changes: 1 addition & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
'lib/internal/dtrace.js',
'lib/internal/encoding.js',
'lib/internal/errors.js',
'lib/internal/error-serdes.js',
'lib/internal/error_serdes.js',
'lib/internal/fixed_queue.js',
'lib/internal/freelist.js',
'lib/internal/freeze_intrinsics.js',
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-bootstrap-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ if (!common.isMainThread) {
expectedModules.add('NativeModule _stream_readable');
expectedModules.add('NativeModule _stream_transform');
expectedModules.add('NativeModule _stream_writable');
expectedModules.add('NativeModule internal/error-serdes');
expectedModules.add('NativeModule internal/error_serdes');
expectedModules.add('NativeModule internal/process/worker_thread_only');
expectedModules.add('NativeModule internal/streams/buffer_list');
expectedModules.add('NativeModule internal/streams/destroy');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-error-serdes.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require('../common');
const assert = require('assert');
const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
const { serializeError, deserializeError } = require('internal/error-serdes');
const { serializeError, deserializeError } = require('internal/error_serdes');

function cycle(err) {
return deserializeError(serializeError(err));
Expand Down

0 comments on commit 4a2accb

Please sign in to comment.