From 4a4970758368c9521be773ace763a8725b8db91a Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 7 Dec 2017 15:35:53 +0100 Subject: [PATCH] crypto: remove BIO_set_shutdown I've not been able to find any reason for calling BIO_set_shutdown(bio, 1). This is done by default for the following versions of OpenSSL: https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/ crypto/bio/bio_lib.c#L26 https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/ crypto/bio/bio_lib.c#L90 https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/ crypto/bio/bio_lib.c#L88 https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/ crypto/bio/bio_lib.c#L90 This commit removes the call and the comment. PR-URL: https://github.com/nodejs/node/pull/17542 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- src/node_crypto_bio.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc index eb0500952b15a5..526d0d4ae568b1 100644 --- a/src/node_crypto_bio.cc +++ b/src/node_crypto_bio.cc @@ -68,8 +68,6 @@ void NodeBIO::AssignEnvironment(Environment* env) { int NodeBIO::New(BIO* bio) { BIO_set_data(bio, new NodeBIO()); - // XXX Why am I doing it?! - BIO_set_shutdown(bio, 1); BIO_set_init(bio, 1); return 1;