Skip to content

Commit

Permalink
test: fix test-https-agent-additional-options.js
Browse files Browse the repository at this point in the history
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Apr 14, 2021
1 parent 09c9e5d commit 4ad8e83
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-https-agent-additional-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ function variations(iter, port, cb) {
server.close();
} else {
// Save `value` for check the next time.
value = next.value.val;
const [key, val] = next.value;
value = val;
https.get({ ...getBaseOptions(port), [key]: val },
variations(iter, port, cb));
}
Expand Down

0 comments on commit 4ad8e83

Please sign in to comment.