From 4c5727271e8b910c31bcb2e650f7b5eb937c4301 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Tue, 2 Jul 2019 14:35:18 -0700 Subject: [PATCH] test: skip stringbytes-external-exceed-max on AIX Add SKIP status for more tests in stringbytes-external-exceed-max that are failing on AIX. --- test/addons/addon.status | 12 ++++++++++++ .../test-stringbytes-external-exceed-max.js | 5 ----- 2 files changed, 12 insertions(+), 5 deletions(-) create mode 100644 test/addons/addon.status diff --git a/test/addons/addon.status b/test/addons/addon.status new file mode 100644 index 00000000000000..6a61fc9d9946ab --- /dev/null +++ b/test/addons/addon.status @@ -0,0 +1,12 @@ +prefix addons + +[true] # This section applies to all platforms + +[$system==aix] +# https://github.com/nodejs/build/issues/1820#issuecomment-505998851 +# https://github.com/nodejs/node/pull/28469 +# https://github.com/nodejs/node/pull/28516 +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP + +# https://github.com/nodejs/node/pull/28516 +stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP diff --git a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js index d6a442f7516c1f..d65144e04d457c 100644 --- a/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js +++ b/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js @@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements'; if (!common.enoughTestMem) common.skip(skipMessage); -// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851 -// See https://github.com/nodejs/node/pull/28469 -if (process.platform === 'aix') - common.skip('flaky on AIX'); - const binding = require(`./build/${common.buildType}/binding`); // v8 fails silently if string length > v8::String::kMaxLength