-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR-URL: #17948 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
- Loading branch information
1 parent
8806e54
commit 51eab4b
Showing
6 changed files
with
34 additions
and
8 deletions.
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
test/parallel/test-regress-GH-1899.js → ...test-child-process-can-write-to-stdout.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
test/parallel/test-regress-GH-819.js → ...arallel/test-net-connect-after-destroy.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
test/parallel/test-regress-GH-746.js → ...test-net-listen-after-destroying-stdin.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
'use strict'; | ||
// Tests that os.userInfo correctly handles errors thrown by option property | ||
// getters. See https://github.com/nodejs/node/issues/12370. | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const execFile = require('child_process').execFile; | ||
|
||
const script = `os.userInfo({ | ||
get encoding() { | ||
throw new Error('xyz'); | ||
} | ||
})`; | ||
|
||
const node = process.execPath; | ||
execFile(node, [ '-e', script ], common.mustCall((err, stdout, stderr) => { | ||
assert(stderr.includes('Error: xyz'), 'userInfo crashes'); | ||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 5 additions & 7 deletions
12
test/parallel/test-regress-GH-12371.js → ...llel/test-vm-api-handles-getter-errors.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters