From 53b0f413cd5346cf392f9b92d267501afcc0a950 Mon Sep 17 00:00:00 2001
From: Adrian Estrada <edsadr@gmail.com>
Date: Wed, 11 Jan 2017 21:10:18 -0500
Subject: [PATCH] test: improve the code in test-process-cpuUsage

* validate the errors for assert.throws
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10714
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/parallel/test-process-cpuUsage.js | 54 ++++++++++++++++++++------
 1 file changed, 42 insertions(+), 12 deletions(-)

diff --git a/test/parallel/test-process-cpuUsage.js b/test/parallel/test-process-cpuUsage.js
index 92dc71918585c3..0c553c576a1f25 100644
--- a/test/parallel/test-process-cpuUsage.js
+++ b/test/parallel/test-process-cpuUsage.js
@@ -33,27 +33,57 @@ for (let i = 0; i < 10; i++) {
   assert(diffUsage.system >= 0);
 }
 
+const invalidUserArgument =
+    /^TypeError: value of user property of argument is invalid$/;
+const invalidSystemArgument =
+    /^TypeError: value of system property of argument is invalid$/;
+
 // Ensure that an invalid shape for the previous value argument throws an error.
-assert.throws(function() { process.cpuUsage(1); });
-assert.throws(function() { process.cpuUsage({}); });
-assert.throws(function() { process.cpuUsage({ user: 'a' }); });
-assert.throws(function() { process.cpuUsage({ system: 'b' }); });
-assert.throws(function() { process.cpuUsage({ user: null, system: 'c' }); });
-assert.throws(function() { process.cpuUsage({ user: 'd', system: null }); });
-assert.throws(function() { process.cpuUsage({ user: -1, system: 2 }); });
-assert.throws(function() { process.cpuUsage({ user: 3, system: -2 }); });
-assert.throws(function() {
+assert.throws(() => {
+  process.cpuUsage(1);
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({});
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ user: 'a' });
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ system: 'b' });
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ user: null, system: 'c' });
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ user: 'd', system: null });
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ user: -1, system: 2 });
+}, invalidUserArgument);
+
+assert.throws(() => {
+  process.cpuUsage({ user: 3, system: -2 });
+}, invalidSystemArgument);
+
+assert.throws(() => {
   process.cpuUsage({
     user: Number.POSITIVE_INFINITY,
     system: 4
   });
-});
-assert.throws(function() {
+}, invalidUserArgument);
+
+assert.throws(() => {
   process.cpuUsage({
     user: 5,
     system: Number.NEGATIVE_INFINITY
   });
-});
+}, invalidSystemArgument);
 
 // Ensure that the return value is the expected shape.
 function validateResult(result) {