Skip to content

Commit

Permalink
test: make test-intl-no-icu-data more robust
Browse files Browse the repository at this point in the history
In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is
loaded. Use another method to check the --icu-data-dir option pointing
to an empty directory.

PR-URL: #10992
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
targos authored and italoacasas committed Mar 1, 2017
1 parent 7b253eb commit 54e55e0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/parallel/test-intl-no-icu-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ require('../common');
const assert = require('assert');
const config = process.binding('config');

// No-op when ICU case mappings are unavailable.
assert.strictEqual('ç'.toLocaleUpperCase('el'), 'ç');
assert.deepStrictEqual(Intl.NumberFormat.supportedLocalesOf('en'), []);
assert.strictEqual(config.icuDataDir, 'test/fixtures/empty/');

0 comments on commit 54e55e0

Please sign in to comment.