From 569f797917056e24d2c92fdf8fbd172e640e3566 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 23 Oct 2019 23:21:02 +0200 Subject: [PATCH] src: remove unimplemented method from node.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This function was not actually available during any part of the Node 12 release line because it had been removed earlier (likely accidentally). Refs: https://github.com/nodejs/node/pull/27220 PR-URL: https://github.com/nodejs/node/pull/30098 Reviewed-By: Colin Ihrig Reviewed-By: David Carlier Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Tobias Nießen Reviewed-By: Yongsheng Zhang Reviewed-By: Jiawen Geng --- src/node.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/node.h b/src/node.h index d5691513992adb..025c6b949dc438 100644 --- a/src/node.h +++ b/src/node.h @@ -280,12 +280,6 @@ class NODE_EXTERN MultiIsolatePlatform : public v8::Platform { void* data) = 0; }; -// Set up some Node.js-specific defaults for `params`, in particular -// the ArrayBuffer::Allocator if it is provided, memory limits, and -// possibly a code event handler. -NODE_EXTERN void SetIsolateCreateParams(v8::Isolate::CreateParams* params, - ArrayBufferAllocator* allocator - = nullptr); // Set a number of callbacks for the `isolate`, in particular the Node.js // uncaught exception listener. NODE_EXTERN void SetIsolateUpForNode(v8::Isolate* isolate);