-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: fix
undefined
in Readable object mode
Fixes `this.push(undefined)`. Fixes: #13753 PR-URL: #13760 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
- Loading branch information
Showing
2 changed files
with
46 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const { Readable, Writable, Transform } = require('stream'); | ||
|
||
{ | ||
const stream = new Readable({ | ||
objectMode: true, | ||
read: common.mustCall(() => { | ||
stream.push(undefined); | ||
stream.push(null); | ||
}) | ||
}); | ||
|
||
stream.on('data', common.mustCall((chunk) => { | ||
assert.strictEqual(chunk, undefined); | ||
})); | ||
} | ||
|
||
{ | ||
const stream = new Writable({ | ||
objectMode: true, | ||
write: common.mustCall((chunk) => { | ||
assert.strictEqual(chunk, undefined); | ||
}) | ||
}); | ||
|
||
stream.write(undefined); | ||
} | ||
|
||
{ | ||
const stream = new Transform({ | ||
objectMode: true, | ||
transform: common.mustCall((chunk) => { | ||
stream.push(chunk); | ||
}) | ||
}); | ||
|
||
stream.on('data', common.mustCall((chunk) => { | ||
assert.strictEqual(chunk, undefined); | ||
})); | ||
|
||
stream.write(undefined); | ||
} |