From 5e1ceaabaadfb11fd8a685466521b21fd51f4cc8 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 20 Jul 2018 14:14:03 -0700 Subject: [PATCH] build: remove redundant Makefile target The only target that uses the `tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a result of a recent change, it has `tools/doc/node_modules` as a prerequisite, which does the exact same npm install as `tools/doc/node_modules/js-yaml/package.json`. Remove `tools/doc/node_modules/js-yaml/package.json` as unnecessary. PR-URL: https://github.com/nodejs/node/pull/21915 Reviewed-By: Joyee Cheung Reviewed-By: Jon Moss Reviewed-By: Trivikram Kamat Reviewed-By: Vse Mozhet Byt Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- Makefile | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Makefile b/Makefile index ae957e118d0eaf..81dbd9f4d19434 100644 --- a/Makefile +++ b/Makefile @@ -619,11 +619,6 @@ apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_as .PHONY: doc-only doc-only: tools/doc/node_modules \ $(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary. -# If it's a source tarball, assets are already in doc/api/assets, -# no need to install anything, we have already copied the docs over - if [ ! -d doc/api/assets ]; then \ - $(MAKE) tools/doc/node_modules/js-yaml/package.json; \ - fi; @$(MAKE) out/doc/api/all.html out/doc/api/all.json .PHONY: doc @@ -662,9 +657,6 @@ available-node = \ run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock run-npm-ci = $(PWD)/$(NPM) ci -tools/doc/node_modules/js-yaml/package.json: - cd tools/doc && $(call available-node,$(run-npm-install)) - gen-json = tools/doc/generate.js --format=json $< > $@ gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \ --analytics=$(DOCS_ANALYTICS) $< > $@