From 5f18991f270754a3dca7f64ba56afe10fbb7627c Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Fri, 30 Nov 2018 17:35:55 +0100 Subject: [PATCH] tools: fix eslint usage for Node.js 8 and before IDEs like vscode use older Node.js versions that do not yet support the new try catch syntax. This makes sure eslint continues to work in these IDEs as before. PR-URL: https://github.com/nodejs/node/pull/24753 Reviewed-By: Richard Lau Reviewed-By: Vse Mozhet Byt Reviewed-By: Rich Trott --- .eslintrc.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 0b4c170813d0a7..23ddc3c95cd39d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -17,7 +17,10 @@ Module._findPath = (request, paths, isMain) => { if (!r && hacks.includes(request)) { try { return require.resolve(`./tools/node_modules/${request}`); - } catch { + // Keep the variable in place to ensure that ESLint started by older Node.js + // versions work as expected. + // eslint-disable-next-line no-unused-vars + } catch (e) { return require.resolve( `./tools/node_modules/eslint/node_modules/${request}`); }