From 6175a22b8703f0b37c54439f20e4c7d97d833f39 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Tue, 24 Mar 2020 13:53:12 -0700 Subject: [PATCH] src: avoid using elevated v8 namespaces in node_errors.h Signed-off-by: James M Snell PR-URL: https://github.com/nodejs/node/pull/32468 Reviewed-By: Anna Henningsen --- src/node_errors.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/node_errors.h b/src/node_errors.h index 48fcdf84867f5f..3c57f4b8b02fee 100644 --- a/src/node_errors.h +++ b/src/node_errors.h @@ -12,14 +12,10 @@ namespace node { -using v8::Local; -using v8::Message; -using v8::Value; - enum ErrorHandlingMode { CONTEXTIFY_ERROR, FATAL_ERROR, MODULE_ERROR }; void AppendExceptionLine(Environment* env, - Local er, - Local message, + v8::Local er, + v8::Local message, enum ErrorHandlingMode mode); [[noreturn]] void FatalError(const char* location, const char* message); @@ -195,8 +191,8 @@ class TryCatchScope : public v8::TryCatch { void TriggerUncaughtException(v8::Isolate* isolate, const v8::TryCatch& try_catch); void TriggerUncaughtException(v8::Isolate* isolate, - Local error, - Local message, + v8::Local error, + v8::Local message, bool from_promise = false); const char* errno_string(int errorno);