From 61f735e03e42b6c02afff8a63dd4b415c3397da2 Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Thu, 24 May 2018 20:56:18 -0700 Subject: [PATCH] build,win: disable DLL-interface warnings Compiling node with vcbuild generates 10,000s of these warnings, originating from v8.h. This makes it impossible to read any other diagnostic messages. Refs: https://github.com/nodejs/node/pull/15570 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/20958 --- common.gypi | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/common.gypi b/common.gypi index dd11d7af3c6350..31196e22535393 100644 --- a/common.gypi +++ b/common.gypi @@ -236,10 +236,18 @@ 'BufferSecurityCheck': 'true', 'ExceptionHandling': 0, # /EHsc 'SuppressStartupBanner': 'true', - # Disable "warning C4267: conversion from 'size_t' to 'int', - # possible loss of data". Many originate from our dependencies - # and their sheer number drowns out other, more legitimate warnings. - 'DisableSpecificWarnings': ['4267'], + # Disable warnings: + # - "C4251: class needs to have dll-interface" + # - "C4275: non-DLL-interface used as base for DLL-interface" + # Over 10k of these warnings are generated when compiling node, + # originating from v8.h. Most of them are false positives. + # See also: https://github.com/nodejs/node/pull/15570 + # TODO: re-enable when Visual Studio fixes these upstream. + # + # - "C4267: conversion from 'size_t' to 'int'" + # Many any originate from our dependencies, and their sheer number + # drowns out other, more legitimate warnings. + 'DisableSpecificWarnings': ['4251', '4275', '4267'], 'WarnAsError': 'false', }, 'VCLinkerTool': {