From 6417564b29327f5c47d3bddef6c70ef6e39a11f7 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Tue, 6 Mar 2018 11:30:25 +0530 Subject: [PATCH] test: rename test-regress-GH-1697 Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil --- ...-regress-GH-1697.js => test-regress-net-response_size.js} | 5 +++++ 1 file changed, 5 insertions(+) rename test/sequential/{test-regress-GH-1697.js => test-regress-net-response_size.js} (91%) diff --git a/test/sequential/test-regress-GH-1697.js b/test/sequential/test-regress-net-response_size.js similarity index 91% rename from test/sequential/test-regress-GH-1697.js rename to test/sequential/test-regress-net-response_size.js index 9d2555705ab023..e6be7fa7273362 100644 --- a/test/sequential/test-regress-GH-1697.js +++ b/test/sequential/test-regress-net-response_size.js @@ -21,6 +21,11 @@ 'use strict'; const common = require('../common'); + +// Make sure the net module's server doesn't throw an error when handling +// responses that are either too long or too small (especially on windows) +// https://github.com/nodejs/node-v0.x-archive/issues/1697 + const net = require('net'); const cp = require('child_process');