From 64cbe7aa9e5613d1e98fa101034b2a087e8a8398 Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Sun, 21 Aug 2016 21:04:23 +0200 Subject: [PATCH] test: fix flaky `test-child-process-pass-fd` Listen on random ports instead of using `common.PORT`. Fixes: https://github.com/nodejs/node/issues/8209 PR-URL: https://github.com/nodejs/node/pull/8212 Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Yorkie Liu --- test/sequential/test-child-process-pass-fd.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/sequential/test-child-process-pass-fd.js b/test/sequential/test-child-process-pass-fd.js index a49baa31a9b9aa..c1d115f9a9db29 100644 --- a/test/sequential/test-child-process-pass-fd.js +++ b/test/sequential/test-child-process-pass-fd.js @@ -14,7 +14,7 @@ const N = 80; if (process.argv[2] !== 'child') { for (let i = 0; i < N; ++i) { - const worker = fork(__filename, ['child', common.PORT + i]); + const worker = fork(__filename, ['child']); worker.once('message', common.mustCall((msg, handle) => { assert.strictEqual(msg, 'handle'); assert.ok(handle); @@ -33,7 +33,6 @@ if (process.argv[2] !== 'child') { } } else { let socket; - const port = process.argv[3]; let cbcalls = 0; function socketConnected() { if (++cbcalls === 2) @@ -47,7 +46,8 @@ if (process.argv[2] !== 'child') { }); socketConnected(); }); - server.listen(port, common.localhostIPv4, () => { + server.listen(0, common.localhostIPv4, () => { + const port = server.address().port; socket = net.connect(port, common.localhostIPv4, socketConnected); }); }