cluster: use ObjectPrototypeHasOwnProperty

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #48141 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs · May 30, 2023 · 6cf2adc · 6cf2adc
1 parent f117855
commit 6cf2adc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/lib/cluster.js b/lib/cluster.js
@@ -21,5 +21,9 @@
 
 'use strict';
 
-const childOrPrimary = 'NODE_UNIQUE_ID' in process.env ? 'child' : 'primary';
+const {
+  ObjectPrototypeHasOwnProperty: ObjectHasOwn,
+} = primordials;
+
+const childOrPrimary = ObjectHasOwn(process.env, 'NODE_UNIQUE_ID') ? 'child' : 'primary';
 module.exports = require(`internal/cluster/${childOrPrimary}`);
diff --git a/test/parallel/test-cluster-basic.js b/test/parallel/test-cluster-basic.js
@@ -22,13 +22,26 @@
 'use strict';
 const common = require('../common');
 
-const assert = require('assert');
-const cluster = require('cluster');
+const assert = require('node:assert');
+const cluster = require('node:cluster');
+const { spawnSync } = require('node:child_process');
 
 assert.strictEqual('NODE_UNIQUE_ID' in process.env, false,
                    `NODE_UNIQUE_ID (${process.env.NODE_UNIQUE_ID}) ` +
                    'should be removed on startup');
 
+{
+  const { status } = spawnSync(process.execPath, [
+    '-e',
+    `
+      const { strictEqual } = require('node:assert');
+      Object.setPrototypeOf(process.env, { NODE_UNIQUE_ID: 0 });
+      strictEqual(require('cluster').isPrimary, true);
+    `,
+  ]);
+  assert.strictEqual(status, 0);
+}
+
 function forEach(obj, fn) {
   Object.keys(obj).forEach((name, index) => {
     fn(obj[name], name, index);