From 716ee1531cf5493940ac9b1ab4ef812279965d91 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 18 Jun 2021 22:27:10 -0700 Subject: [PATCH] debugger: rename internal library for clarity When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: https://github.com/nodejs/node/pull/39080 Backport-PR-URL: https://github.com/nodejs/node/pull/39446 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig --- lib/internal/{inspector => debugger}/_inspect.js | 4 ++-- lib/internal/{inspector => debugger}/inspect_client.js | 0 lib/internal/{inspector => debugger}/inspect_repl.js | 0 lib/internal/main/inspect.js | 2 +- node.gyp | 6 +++--- 5 files changed, 6 insertions(+), 6 deletions(-) rename lib/internal/{inspector => debugger}/_inspect.js (98%) rename lib/internal/{inspector => debugger}/inspect_client.js (100%) rename lib/internal/{inspector => debugger}/inspect_repl.js (100%) diff --git a/lib/internal/inspector/_inspect.js b/lib/internal/debugger/_inspect.js similarity index 98% rename from lib/internal/inspector/_inspect.js rename to lib/internal/debugger/_inspect.js index 526545d3abc761..c8e38512bb8297 100644 --- a/lib/internal/inspector/_inspect.js +++ b/lib/internal/debugger/_inspect.js @@ -43,8 +43,8 @@ const console = require('internal/console/global'); const { 0: InspectClient, 1: createRepl } = [ - require('internal/inspector/inspect_client'), - require('internal/inspector/inspect_repl'), + require('internal/debugger/inspect_client'), + require('internal/debugger/inspect_repl'), ]; const debuglog = util.debuglog('inspect'); diff --git a/lib/internal/inspector/inspect_client.js b/lib/internal/debugger/inspect_client.js similarity index 100% rename from lib/internal/inspector/inspect_client.js rename to lib/internal/debugger/inspect_client.js diff --git a/lib/internal/inspector/inspect_repl.js b/lib/internal/debugger/inspect_repl.js similarity index 100% rename from lib/internal/inspector/inspect_repl.js rename to lib/internal/debugger/inspect_repl.js diff --git a/lib/internal/main/inspect.js b/lib/internal/main/inspect.js index 10e7cbf2c2b48a..731ff1cd0dc7f0 100644 --- a/lib/internal/main/inspect.js +++ b/lib/internal/main/inspect.js @@ -18,5 +18,5 @@ markBootstrapComplete(); // Start the debugger agent. process.nextTick(() => { - require('internal/inspector/_inspect').start(); + require('internal/debugger/_inspect').start(); }); diff --git a/node.gyp b/node.gyp index ce902069ed6bac..8ba0dfebe890e8 100644 --- a/node.gyp +++ b/node.gyp @@ -125,6 +125,9 @@ 'lib/internal/crypto/sig.js', 'lib/internal/crypto/util.js', 'lib/internal/constants.js', + 'lib/internal/debugger/_inspect.js', + 'lib/internal/debugger/inspect_client.js', + 'lib/internal/debugger/inspect_repl.js', 'lib/internal/dgram.js', 'lib/internal/dns/promises.js', 'lib/internal/dns/utils.js', @@ -148,9 +151,6 @@ 'lib/internal/heap_utils.js', 'lib/internal/histogram.js', 'lib/internal/idna.js', - 'lib/internal/inspector/_inspect.js', - 'lib/internal/inspector/inspect_client.js', - 'lib/internal/inspector/inspect_repl.js', 'lib/internal/inspector_async_hook.js', 'lib/internal/js_stream_socket.js', 'lib/internal/linkedlist.js',