From 7f3aec7e41bfd4af3d58e319463e59136abc37e2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 19 Nov 2019 06:45:06 -0800 Subject: [PATCH] test: use reserved .invalid TLD for invalid address in test RFC 2606 reserves ithe .invalid top-level-domain for use in "domain names that are sure to be invalid and which it is obvious at a glance are invalid." Replace `dne.example.com` which actually isn't guaranteed to not exist. (example.com is for examples, but at least one address does in fact exist in that TLD.) PR-URL: https://github.com/nodejs/node/pull/30545 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca --- test/internet/test-dgram-send-cb-quelches-error.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/internet/test-dgram-send-cb-quelches-error.js b/test/internet/test-dgram-send-cb-quelches-error.js index d989a13216ab10..106d2870c2fd42 100644 --- a/test/internet/test-dgram-send-cb-quelches-error.js +++ b/test/internet/test-dgram-send-cb-quelches-error.js @@ -24,7 +24,7 @@ function callbackOnly(err) { assert.ok(err); socket.removeListener('error', onEvent); socket.on('error', mustCall(onError)); - socket.send(buffer, 0, buffer.length, 100, 'dne.example.com'); + socket.send(buffer, 0, buffer.length, 100, 'dne.invalid'); } function onEvent(err) {