From 7fb4794e191931c776327cc8cac1f80af81b7142 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 17 Jul 2016 09:33:35 -0700 Subject: [PATCH] test: increase RAM requirement for intensive tests test-fs-read-buffer-tostring-fail and test-fs-readfile-tostring-fail have been timing out on Raspberry Pi 3 devices on the continuous integration server. These devices have 1 Gb of RAM and the tests are memory intensive. Previous checks for memory intensive tests used a 512 Mb cut-off, but that was probably instituted when we only had Pi 1 devices. Consequently, this change increases the threshold for memory-intensive tests to 1 Gb and adds that threshold to test-fs-readfile-tostring-fail. PR-URL: https://github.com/nodejs/node/pull/7772 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno Reviewed-By: Michael Dawson --- test/common.js | 2 +- test/parallel/test-fs-readfile-tostring-fail.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/test/common.js b/test/common.js index 308411a13d3427..aacea9ae768fc7 100644 --- a/test/common.js +++ b/test/common.js @@ -27,7 +27,7 @@ exports.isLinuxPPCBE = (process.platform === 'linux') && exports.isSunOS = process.platform === 'sunos'; exports.isFreeBSD = process.platform === 'freebsd'; -exports.enoughTestMem = os.totalmem() > 0x20000000; /* 512MB */ +exports.enoughTestMem = os.totalmem() > 0x40000000; /* 1 Gb */ exports.rootDir = exports.isWindows ? 'c:\\' : '/'; function rimrafSync(p) { diff --git a/test/parallel/test-fs-readfile-tostring-fail.js b/test/parallel/test-fs-readfile-tostring-fail.js index c61fa2c712714e..8ed9658a25889a 100644 --- a/test/parallel/test-fs-readfile-tostring-fail.js +++ b/test/parallel/test-fs-readfile-tostring-fail.js @@ -1,6 +1,13 @@ 'use strict'; const common = require('../common'); + +if (!common.enoughTestMem) { + const skipMessage = 'intensive toString tests due to memory confinements'; + common.skip(skipMessage); + return; +} + const assert = require('assert'); const fs = require('fs'); const path = require('path');