Skip to content

Commit

Permalink
doc: amplify warning for execute callback
Browse files Browse the repository at this point in the history
Add specific recommendation not to use the
to the napi-env parameter in napi_async_execute_callback

PR-URL: #28738
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
mhdawson authored and targos committed Jul 22, 2019
1 parent 5c10007 commit 8fe9ca4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,8 @@ Implementations of this type of function should avoid making any N-API calls
that could result in the execution of JavaScript or interaction with
JavaScript objects. Most often, any code that needs to make N-API
calls should be made in `napi_async_complete_callback` instead.
Avoid using the `napi_env` parameter in the execute callback as
it will likely execute JavaScript.

#### napi_async_complete_callback
<!-- YAML
Expand Down Expand Up @@ -4028,6 +4030,8 @@ The `execute` function should avoid making any N-API calls
that could result in the execution of JavaScript or interaction with
JavaScript objects. Most often, any code that needs to make N-API
calls should be made in `complete` callback instead.
Avoid using the `napi_env` parameter in the execute callback as
it will likely execute JavaScript.

These functions implement the following interfaces:

Expand Down

0 comments on commit 8fe9ca4

Please sign in to comment.