lib: enable dot-notation eslint rule

PR-URL: #18007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

lib/.eslintrc.yaml

@@ -1,4 +1,6 @@
 rules:
+  dot-notation: error
+
   # Custom rules in tools/eslint-rules
   require-buffer: error
   buffer-constructor: error

lib/_debugger.js

@@ -742,9 +742,9 @@ function Interface(stdin, stdout, args) {
     useGlobal: false,
     ignoreUndefined: true
   };
-  if (parseInt(process.env['NODE_NO_READLINE'], 10)) {
+  if (parseInt(process.env.NODE_NO_READLINE, 10)) {
     opts.terminal = false;
-  } else if (parseInt(process.env['NODE_FORCE_READLINE'], 10)) {
+  } else if (parseInt(process.env.NODE_FORCE_READLINE, 10)) {
     opts.terminal = true;
 
     // Emulate Ctrl+C if we're emulating terminal
@@ -754,7 +754,7 @@ function Interface(stdin, stdout, args) {
       });
     }
   }
-  if (parseInt(process.env['NODE_DISABLE_COLORS'], 10)) {
+  if (parseInt(process.env.NODE_DISABLE_COLORS, 10)) {
     opts.useColors = false;
   }
 

lib/internal/child_process.js

@@ -383,7 +383,7 @@ ChildProcess.prototype.kill = function(sig) {
   if (sig === 0) {
     signal = 0;
   } else if (!sig) {
-    signal = constants['SIGTERM'];
+    signal = constants.SIGTERM;
   } else {
     signal = constants[sig];
   }

lib/module.js

@@ -639,7 +639,7 @@ Module._initPaths = function() {
     paths.unshift(path.resolve(homeDir, '.node_modules'));
   }
 
-  var nodePath = process.env['NODE_PATH'];
+  var nodePath = process.env.NODE_PATH;
   if (nodePath) {
     paths = nodePath.split(path.delimiter).filter(function(path) {
       return !!path;