Skip to content

Commit

Permalink
doc: simplify COLLABORATOR_GUIDE.md instructions
Browse files Browse the repository at this point in the history
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` to `name` and remove italics to avoid
incorrect implication that we need a "legal name".

PR-URL: #19458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information
Trott authored and targos committed Mar 24, 2018
1 parent e5bcd8d commit 98d038a
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -494,12 +494,11 @@ The TSC should serve as the final arbiter where required.
one](https://github.com/nodejs/node/commit/b636ba8186) if unsure exactly how
to format your commit messages.

Additionally:
Check PRs from new contributors to make sure the person's name and email address
are correct before merging.

* Double check PRs to make sure the person's _full name_ and email
address are correct before merging.
* All commits should be self-contained (meaning every commit should pass all
tests). This makes it much easier when bisecting to find a breaking change.
All commits should be self-contained, meaning every commit should pass all
tests. This makes it much easier when bisecting to find a breaking change.

### Using `git-node`

Expand Down

0 comments on commit 98d038a

Please sign in to comment.