lib: allow respondWithNewView on byob auto allocated streams

Fixes: #41886 PR-URL: #41887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs · Apr 24, 2022 · 9946b9b · 9946b9b
1 parent b0a8311
commit 9946b9b
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2604,6 +2604,7 @@ function readableByteStreamControllerPullSteps(controller, readRequest) {
         pendingPullIntos,
         {
           buffer,
+          bufferByteLength: autoAllocateChunkSize,
           byteOffset: 0,
           byteLength: autoAllocateChunkSize,
           bytesFilled: 0,

diff --git a/test/parallel/test-whatwg-readablebytestream.js b/test/parallel/test-whatwg-readablebytestream.js
@@ -232,3 +232,33 @@ class Source {
     code: 'ERR_INVALID_STATE',
   });
 }
+
+{
+  const stream = new ReadableStream({
+    type: 'bytes',
+    pull(c) {
+      const v = new Uint8Array(c.byobRequest.view.buffer, 0, 3);
+      v.set([20, 21, 22]);
+      c.byobRequest.respondWithNewView(v);
+    },
+  });
+  const buffer = new ArrayBuffer(10);
+  const view = new Uint8Array(buffer, 0, 3);
+  view.set([10, 11, 12]);
+  const reader = stream.getReader({ mode: 'byob' });
+  reader.read(view);
+}
+
+{
+  const stream = new ReadableStream({
+    type: 'bytes',
+    autoAllocateChunkSize: 10,
+    pull(c) {
+      const v = new Uint8Array(c.byobRequest.view.buffer, 0, 3);
+      v.set([20, 21, 22]);
+      c.byobRequest.respondWithNewView(v);
+    },
+  });
+  const reader = stream.getReader();
+  reader.read();
+}