Skip to content

Commit

Permalink
bootstrap: fix wasm_web_api external reference registration
Browse files Browse the repository at this point in the history
The external references were not actually registered.

PR-URL: #42903
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
joyeecheung authored and RafaelGSS committed May 10, 2022
1 parent e74a8da commit 9ee7d9e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/node_external_reference.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ class ExternalReferenceRegistry {
V(uv) \
V(v8) \
V(zlib) \
V(wasm_web_api) \
V(worker)

#if NODE_HAVE_I18N_SUPPORT
Expand Down
3 changes: 3 additions & 0 deletions src/node_wasm_web_api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Local<Function> WasmStreamingObject::Initialize(Environment* env) {

void WasmStreamingObject::RegisterExternalReferences(
ExternalReferenceRegistry* registry) {
registry->Register(New);
registry->Register(Push);
registry->Register(Finish);
registry->Register(Abort);
Expand Down Expand Up @@ -198,6 +199,8 @@ void Initialize(Local<Object> target,

void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(SetImplementation);
registry->Register(StartStreamingCompilation);
WasmStreamingObject::RegisterExternalReferences(registry);
}

} // namespace wasm_web_api
Expand Down

0 comments on commit 9ee7d9e

Please sign in to comment.