From a0c566f85a7632a47a65b27018778bc129fd6311 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Mon, 26 Apr 2021 05:54:35 -0700
Subject: [PATCH] debugger: apply automatic lint fixes for inspect_repl.js
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

For issues that ESLint can fix automatically, fix them.

PR-URL: https://github.com/nodejs/node/pull/38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
---
 lib/internal/inspector/inspect_repl.js | 31 ++++++++++++++------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/lib/internal/inspector/inspect_repl.js b/lib/internal/inspector/inspect_repl.js
index 4827ad1f914c86..ab75abddd408db 100644
--- a/lib/internal/inspector/inspect_repl.js
+++ b/lib/internal/inspector/inspect_repl.js
@@ -353,6 +353,7 @@ function createRepl(inspector) {
       })
       .join('\n');
   }
+
   function listScripts(displayNatives = false) {
     print(formatScripts(displayNatives));
   }
@@ -402,9 +403,9 @@ function createRepl(inspector) {
         const i = start + offset;
         const isCurrent = i === (lineNumber + 1);
 
-        const markedLine = isCurrent
-          ? markSourceColumn(lineText, columnNumber, options.colors)
-          : lineText;
+        const markedLine = isCurrent ?
+          markSourceColumn(lineText, columnNumber, options.colors) :
+          lineText;
 
         let isBreakpoint = false;
         knownBreakpoints.forEach(({ location }) => {
@@ -488,7 +489,7 @@ function createRepl(inspector) {
 
   function prepareControlCode(input) {
     if (input === '\n') return lastCommand;
-    // exec process.title => exec("process.title");
+    // Add parentheses: exec process.title => exec("process.title");
     const match = input.match(/^\s*exec\s+([^\n]*)/);
     if (match) {
       lastCommand = `exec(${JSON.stringify(match[1])})`;
@@ -678,13 +679,13 @@ function createRepl(inspector) {
     // setBreakpoint('fn()'): Break when a function is called
     if (script.endsWith('()')) {
       const debugExpr = `debug(${script.slice(0, -2)})`;
-      const debugCall = selectedFrame
-        ? Debugger.evaluateOnCallFrame({
+      const debugCall = selectedFrame ?
+        Debugger.evaluateOnCallFrame({
           callFrameId: selectedFrame.callFrameId,
           expression: debugExpr,
           includeCommandLineAPI: true,
-        })
-        : Runtime.evaluate({
+        }) :
+        Runtime.evaluate({
           expression: debugExpr,
           includeCommandLineAPI: true,
         });
@@ -807,7 +808,7 @@ function createRepl(inspector) {
 
     inspector.suspendReplWhile(() =>
       Promise.all([formatWatchers(true), selectedFrame.list(2)])
-        .then(([watcherList, context]) => {
+        .then(({ 0: watcherList, 1: context }) => {
           if (watcherList) {
             return `${watcherList}\n${inspect(context)}`;
           }
@@ -829,9 +830,7 @@ function createRepl(inspector) {
   Debugger.on('scriptParsed', (script) => {
     const { scriptId, url } = script;
     if (url) {
-      knownScripts[scriptId] = Object.assign({
-        isNative: isNativeUrl(url),
-      }, script);
+      knownScripts[scriptId] = { isNative: isNativeUrl(url), ...script };
     }
   });
 
@@ -839,7 +838,7 @@ function createRepl(inspector) {
     Profile.createAndRegister({ profile });
     print([
       'Captured new CPU profile.',
-      `Access it with profiles[${profiles.length - 1}]`
+      `Access it with profiles[${profiles.length - 1}]`,
     ].join('\n'));
   });
 
@@ -931,11 +930,13 @@ function createRepl(inspector) {
               print(`Heap snapshot: ${done}/${total}`, false);
             }
           }
+
           function onChunk({ chunk }) {
             sizeWritten += chunk.length;
             writer.write(chunk);
             print(`Writing snapshot: ${sizeWritten}`, false);
           }
+
           function onResolve() {
             writer.end(() => {
               teardown();
@@ -943,10 +944,12 @@ function createRepl(inspector) {
               resolve();
             });
           }
+
           function onReject(error) {
             teardown();
             reject(error);
           }
+
           function teardown() {
             HeapProfiler.removeListener(
               'reportHeapSnapshotProgress', onProgress);
@@ -1071,7 +1074,7 @@ function createRepl(inspector) {
       .then(() => Debugger.setBlackboxPatterns({ patterns: [] }))
       .then(() => Debugger.setPauseOnExceptions({ state: pauseOnExceptionState }))
       .then(() => restoreBreakpoints())
-      .then(() => Runtime.runIfWaitingForDebugger())
+      .then(() => Runtime.runIfWaitingForDebugger());
   }
 
   return function startRepl() {