From a766f6dea5190f92e195c80dcb9af5ad9db25110 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 11 Oct 2017 04:56:21 +0200 Subject: [PATCH] doc: exempt test/doc only changes from 48-hr rule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a change affects only specific parts of the tests and or documentation, and in particular not of the runtime code itself, it should often be okay to land it early. The primary goal of the 48-hour rule is to ensure that people who are invested in certain parts of Node have a reasonable chance to weigh in based on their usage of Node; if the API is not touched in a change, that is arguably much less of an issue. In particular, this: - Should help avoid excessive nitpicking. - Helps newcomers, since their first PRs often touch only those areas and a direct success is very motivating. - Helps with the amount of pull requests created by events such a Code & Learn. PR-URL: https://github.com/nodejs/node/pull/16135 Reviewed-By: Michaël Zasso Reviewed-By: Stephen Belanger Reviewed-By: Joyee Cheung Reviewed-By: Gireesh Punathil Reviewed-By: Luigi Pinca Reviewed-By: Myles Borins Reviewed-By: Michael Dawson Reviewed-By: Evan Lucas Reviewed-By: Jeremiah Senkpiel Reviewed-By: Ali Ijaz Sheikh Reviewed-By: Colin Ihrig Reviewed-By: Franziska Hinkelmann Reviewed-By: James M Snell --- COLLABORATOR_GUIDE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 7c47d1f4cef9f3..f60eba21aaf2b3 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -64,7 +64,9 @@ from other Collaborators. Leave at least 48 hours during the week and 72 hours over weekends to account for international time differences and work schedules. Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other -wide-reaching impact) may be landed after a shorter delay. +wide-reaching impact), and focused changes that affect only documentation +and/or the test suite, may be landed after a shorter delay if they have +multiple approvals. For non-breaking changes, if there is no disagreement amongst Collaborators, a pull request may be landed given appropriate review.