From ae65f8c3af932cc78dea874e096c477884ff1c7d Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 2 Dec 2019 06:13:57 -0800 Subject: [PATCH] doc: remove imprecise and redundant testing text Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: https://github.com/nodejs/node/pull/30763 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau --- BUILDING.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index b44604ecf07734..dec0dc868f0c82 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -67,13 +67,11 @@ There are three support tiers: * **Tier 1**: These platforms represent the majority of Node.js users. The Node.js Build Working Group maintains infrastructure for full test coverage. - All commits to the Node.js repository are tested on these platforms. Test - failures on tier 1 platforms will block releases. + Test failures on tier 1 platforms will block releases. * **Tier 2**: These platforms represent smaller segments of the Node.js user base. The Node.js Build Working Group maintains infrastructure for full test - coverage. All commits to the Node.js repository are tested on these platforms. - Test failures on tier 2 platforms will block releases. Delays in release of - binaries for these platforms are acceptable where necessary due to + coverage. Test failures on tier 2 platforms will block releases. Delays in + release of binaries for these platforms are acceptable where necessary due to infrastructure concerns. * **Experimental**: May not compile or test suite may not pass. The core team does not create releases for these platforms. Test failures on experimental