Skip to content

Commit

Permalink
test: remove FIXME pummel/test-tls-securepair-client
Browse files Browse the repository at this point in the history
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
ALJCepeda authored and Fishrock123 committed Oct 11, 2016
1 parent c4d9b54 commit b579fca
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions test/pummel/test-tls-securepair-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,14 @@ function test2() {
}

function test(keyfn, certfn, check, next) {
// FIXME: Avoid the common PORT as this test currently hits a C-level
// assertion error with node_g. The program aborts without HUPing
// the openssl s_server thus causing many tests to fail with
// EADDRINUSE.
var PORT = common.PORT + 5;

keyfn = join(common.fixturesDir, keyfn);
var key = fs.readFileSync(keyfn).toString();

certfn = join(common.fixturesDir, certfn);
var cert = fs.readFileSync(certfn).toString();

var server = spawn(common.opensslCli, ['s_server',
'-accept', PORT,
'-accept', common.PORT,
'-cert', certfn,
'-key', keyfn]);
server.stdout.pipe(process.stdout);
Expand Down Expand Up @@ -121,7 +115,7 @@ function test(keyfn, certfn, check, next) {
pair.encrypted.pipe(s);
s.pipe(pair.encrypted);

s.connect(PORT);
s.connect(common.PORT);

s.on('connect', function() {
console.log('client connected');
Expand Down

0 comments on commit b579fca

Please sign in to comment.