From b579fcab45ca466aaa41cfac9f7754074f19fd5f Mon Sep 17 00:00:00 2001 From: Alfred Cepeda Date: Sat, 24 Sep 2016 07:26:05 -0400 Subject: [PATCH] test: remove FIXME pummel/test-tls-securepair-client Reverts: 85827bd Using `common.PORT` no longer causes other tests to fail Refs: https://github.com/nodejs/node/issues/4640 PR-URL: https://github.com/nodejs/node/pull/8757 Reviewed-By: James M Snell Reviewed-By: Ilkka Myller Reviewed-By: Luigi Pinca --- test/pummel/test-tls-securepair-client.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/test/pummel/test-tls-securepair-client.js b/test/pummel/test-tls-securepair-client.js index 5dd2af65b2ba5f..7a1b8770132e96 100644 --- a/test/pummel/test-tls-securepair-client.js +++ b/test/pummel/test-tls-securepair-client.js @@ -39,12 +39,6 @@ function test2() { } function test(keyfn, certfn, check, next) { - // FIXME: Avoid the common PORT as this test currently hits a C-level - // assertion error with node_g. The program aborts without HUPing - // the openssl s_server thus causing many tests to fail with - // EADDRINUSE. - var PORT = common.PORT + 5; - keyfn = join(common.fixturesDir, keyfn); var key = fs.readFileSync(keyfn).toString(); @@ -52,7 +46,7 @@ function test(keyfn, certfn, check, next) { var cert = fs.readFileSync(certfn).toString(); var server = spawn(common.opensslCli, ['s_server', - '-accept', PORT, + '-accept', common.PORT, '-cert', certfn, '-key', keyfn]); server.stdout.pipe(process.stdout); @@ -121,7 +115,7 @@ function test(keyfn, certfn, check, next) { pair.encrypted.pipe(s); s.pipe(pair.encrypted); - s.connect(PORT); + s.connect(common.PORT); s.on('connect', function() { console.log('client connected');