Skip to content

Commit

Permalink
build: allow enabling the --trace-maps flag in V8
Browse files Browse the repository at this point in the history
This can be useful for tracing map creation.

Backport-PR-URL: #14344
Backport-Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Backport-Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
evanlucas authored and addaleax committed Jul 18, 2017
1 parent 3bd18c5 commit b757105
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,11 @@ parser.add_option('--enable-d8',
dest='enable_d8',
help=optparse.SUPPRESS_HELP) # Unsupported, undocumented.

parser.add_option('--enable-trace-maps',
action='store_true',
dest='trace_maps',
help='Enable the --trace-maps flag in V8 (use at your own risk)')

parser.add_option('--v8-options',
action='store',
dest='v8_options',
Expand Down Expand Up @@ -956,6 +961,7 @@ def configure_v8(o):
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
o['variables']['v8_use_snapshot'] = b(options.with_snapshot)
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8)
o['variables']['force_dynamic_crt'] = 1 if options.shared else 0
Expand Down
1 change: 1 addition & 0 deletions node.gyp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
'variables': {
'v8_use_snapshot%': 'false',
'v8_trace_maps%': 0,
'node_use_dtrace%': 'false',
'node_use_lttng%': 'false',
'node_use_etw%': 'false',
Expand Down

0 comments on commit b757105

Please sign in to comment.