From ba0ffddd2db45ee5c9e16bd6b6200a0fac441637 Mon Sep 17 00:00:00 2001 From: Serg Kryvonos Date: Sun, 31 Dec 2023 02:26:30 +0100 Subject: [PATCH] build: fix for VScode "Reopen in Container" PR-URL: https://github.com/nodejs/node/pull/51271 Reviewed-By: Tierney Cyren Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca --- .devcontainer/Dockerfile | 1 - .../{.devcontainer.json => devcontainer.json} | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) delete mode 100644 .devcontainer/Dockerfile rename .devcontainer/{.devcontainer.json => devcontainer.json} (57%) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile deleted file mode 100644 index 3e8e7ecbfbcbdd..00000000000000 --- a/.devcontainer/Dockerfile +++ /dev/null @@ -1 +0,0 @@ -FROM nodejs/devcontainer:nightly diff --git a/.devcontainer/.devcontainer.json b/.devcontainer/devcontainer.json similarity index 57% rename from .devcontainer/.devcontainer.json rename to .devcontainer/devcontainer.json index 2e3cde606ce422..a69b66f442b666 100644 --- a/.devcontainer/.devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,12 +1,12 @@ { "name": "Node.js Core Developer Environment", "extensions": [ - "github.vscode-pull-request-github", - "ms-vsliveshare.vsliveshare", - "vscode-icons-team.vscode-icons", - "visualstudioexptteam.vscodeintellicode" + "github.vscode-pull-request-github", + "ms-vsliveshare.vsliveshare", + "vscode-icons-team.vscode-icons", + "visualstudioexptteam.vscodeintellicode" ], - "dockerFile": "Dockerfile", + "image": "nodejs/devcontainer:nightly", "initializeCommand": "docker system prune -f -a", "settings": { "terminal.integrated.profiles.linux": {